-
Notifications
You must be signed in to change notification settings - Fork 194
Stav/remove prover input info #2149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
af4eb78
to
a354647
Compare
|
a354647
to
a448ce5
Compare
Benchmark Results for unmodified programs 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @Stavbe)
vm/src/vm/runners/cairo_runner.rs
line 1532 at r1 (raw file):
} /// Returns a map from the builtin segment index into its name.
Add to the documentation the fact that Arena isn't returned
Code quote:
/// Returns a map from the builtin segment index into its name.
a448ce5
to
cde7b3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @anatgstarkware)
vm/src/vm/runners/cairo_runner.rs
line 1532 at r1 (raw file):
Previously, anatgstarkware (anatg) wrote…
Add to the documentation the fact that Arena isn't returned
Deleted as discussed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## starkware-development #2149 +/- ##
======================================================
Coverage 96.63% 96.63%
======================================================
Files 104 103 -1
Lines 43915 43865 -50
======================================================
- Hits 42436 42389 -47
+ Misses 1479 1476 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @Stavbe)
vm/src/vm/runners/cairo_runner.rs
line 1513 at r2 (raw file):
.trace .as_deref() .ok_or(TraceError::TraceNotEnabled)?)
Suggestion:
self
.vm
.trace
.as_deref()
.ok_or(TraceError::TraceNotEnabled)
vm/src/vm/runners/cairo_runner.rs
line 1528 at r2 (raw file):
/// Returns a reference to the public memory offsets. pub fn get_public_memory_offsets(&self) -> &HashMap<usize, Vec<(usize, usize)>> {
Is this one necessary?
Code quote:
pub fn get_public_memory_offsets(&self)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @Stavbe)
vm/src/vm/runners/cairo_runner.rs
line 1533 at r2 (raw file):
/// Returns a map from the builtin segment index into its name. pub fn get_builtins_segments(&self) -> BTreeMap<usize, BuiltinName> {
Suggestion:
get_builtin_segments
cde7b3f
to
ac3a5f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @anatgstarkware)
vm/src/vm/runners/cairo_runner.rs
line 1528 at r2 (raw file):
Previously, anatgstarkware (anatg) wrote…
Is this one necessary?
Nope
vm/src/vm/runners/cairo_runner.rs
line 1513 at r2 (raw file):
.trace .as_deref() .ok_or(TraceError::TraceNotEnabled)?)
Done.
ac3a5f0
to
9814009
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Stavbe)
* Add starkware-development to CI (like another main) (#2025) * Keep None memory cells for the prover input info (#2021) * CI: Fix cache not found error (#2026) * Fix flow notation * Fix dependency * Remove dependancy in cairo pie when collectiog builtin segments info (#2022) * Add Commit Signing section (#2019) * Add Commit Signing section * Clarify that this only affects to internal branches Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Franco Giachetta <[email protected]> * use btreemap instead of hashmap for deterministic iteration order. (#2023) * fill holes is builtins segments * fill holes is builtins segments * Added hints felt unpacking for blake (#2032) This PR is an as-is copy of AlonT's PR pushed to a fork repo. * add prover input info flag to vm-cli * set disable trace padding for prover input info * Add_perp_and_dex_w_bitwise_layouts (#2067) * Fix_zero_offset_output_base_assumption (#2068) * add flag to serialize prover input info into binary files * Use_btreemap_for_deterministic_order_of_pie_keys (#2085) * [BREAKING] Compute_missing_builtin_cells_only_in_proof_mode (#2088) * move prover input info to a new seperate file (#2079) * add trace not enabled error * add test to filling holes (#2087) * memory comparision test only for non proof mode cases * Sync with main (#2116) * Remove duplicated `get_val` (#2065) * avoid installing gmp if it is already installed * revert part of the last commit * changelog * remove unwanted file * CI: Make cache keys depend on Cairo version (#2056) * Add Makefile and requirements.txt to cache key * Don't fetch cairo stwo exclusive programs * Remove empty file * Restrict caching Cairo programs Revert how the Rust workflow uses the Cairo program paths to calculate the cache keys. This change would imply the branch only adds Makefile and requirements.txt to the cache key computation. --------- Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> * dev: make Memory::get `pub` (#2039) * dev: make Memory::get `pub` * edit changelog * dev: expose get_maybe_relocatable instead * add comment on borrowed variant * add tests * feat(breaking): add support for hint accessible scopes (#2042) * feat: add support for hint accessible scopes update changelog * Update vm/src/hint_processor/hint_processor_definition.rs Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> * feat: add support for alias identifiers destination in program serde (#2071) * feat: add support for aliases destination in program serde * add changelog --------- Co-authored-by: Julián González Calderón <[email protected]> * fix: Add boundary tests for SecpSplitOutOfRange in secp_utils (#2062) * fix: Add boundary tests for SecpSplitOutOfRange in secp_utils * Update secp_utils.rs * Update CHANGELOG.md * Update secp_utils.rs * remove optimizations * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * empty commit to fix CI --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> * docs: add --run_from_cairo_pie documentation for Cairo 0 and Cairo 1 (#2077) * docs: add --run_from_cairo_pie flag usage documentation for Cairo 0 * docs: add --run_from_cairo_pie flag usage documentation for Cairo 1 * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Update README.md * Update README.md * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Update README.md Co-authored-by: Gabriel Bosio <[email protected]> * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> * Fix WRITE_DIVMOD_SEGMENT hint (#2078) * Minor fixes - use CAIRO_PRIME * Add error handling * Update CHANGELOG.md * Bump cairo-lang to 0.13.5 (#1959) * Update cairo-lang versin * Update changelog * Add new hints * Specify prime in new hints * Only apply mod floor if prime is not CAIRO_PRIME * Properly implement pack for a different prime * Fix pack in compute_doubling_slope * Add negative_points.cairo test * Add try_get_point_from_x for negative points * Add double_x test for negative points * Allow to many arguments * Add codecov to cairo-0-secp-hints feature * Prepare for Release v3.0.0-rc.1 (#2092) * Update version * Update lock * Update toolchain * Update changelog * Fix clippy * Update toolchain in CI * fix: correct cache keys for no-std test coverage in CI (#2093) * Update rust.yml * Update rust.yml * Update rust toolchain to 1.87.0 (#2100) * update rust toolchain to 1.87.0 * remove uneeded file * update rust in workflows * update changelog * clippy * clippy * remove unneeded clippy allow * fix Changelog link (#2104) * Improve memory_segments coverage (#2110) * Add tests for .gen_arg() and .write_arg() * Add test for .is_valid_memory_value() * Assert contents of memory segments --------- Co-authored-by: Franco Giachetta <[email protected]> Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Mathieu <[email protected]> Co-authored-by: VolodymyrBg <[email protected]> Co-authored-by: GarmashAlex <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: DiegoC <[email protected]> * Revert "Sync with main (#2116)" (#2117) This reverts commit 7269a8f. * Bump cairo-lang to 0.13.5 (#1959) (#2118) * Update cairo-lang versin * Update changelog * Add new hints * Specify prime in new hints * Only apply mod floor if prime is not CAIRO_PRIME * Properly implement pack for a different prime * Fix pack in compute_doubling_slope * Add negative_points.cairo test * Add try_get_point_from_x for negative points * Add double_x test for negative points * Allow to many arguments * Add codecov to cairo-0-secp-hints feature Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Enable_using_secure_run_in_proof_mode (#2113) * take ownershop instad of clone * Fixed bad submodule (#2131) * Added support for large files in PIE (#2136) * [starkware-development] Pin types-rs version to the one set in lockfile (#2142) * Update changelog * Pin types-rs version * Include_output_builtin_in_prover_input_info (#2138) * add relocate trace flag to the runner * remove prover input info struct and add getters instead (#2149) * Use_BTreeMap_in_pie_additional_data (#2162) --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> Co-authored-by: Franco Giachetta <[email protected]> Co-authored-by: yuvalsw <[email protected]> Co-authored-by: YairVaknin-starkware <[email protected]> Co-authored-by: Mathieu <[email protected]> Co-authored-by: VolodymyrBg <[email protected]> Co-authored-by: GarmashAlex <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: DiegoC <[email protected]>
* Add starkware-development to CI (like another main) (#2025) * Keep None memory cells for the prover input info (#2021) * CI: Fix cache not found error (#2026) * Fix flow notation * Fix dependency * Remove dependancy in cairo pie when collectiog builtin segments info (#2022) * Add Commit Signing section (#2019) * Add Commit Signing section * Clarify that this only affects to internal branches Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Franco Giachetta <[email protected]> * use btreemap instead of hashmap for deterministic iteration order. (#2023) * fill holes is builtins segments * fill holes is builtins segments * Added hints felt unpacking for blake (#2032) This PR is an as-is copy of AlonT's PR pushed to a fork repo. * add prover input info flag to vm-cli * set disable trace padding for prover input info * Add_perp_and_dex_w_bitwise_layouts (#2067) * Fix_zero_offset_output_base_assumption (#2068) * add flag to serialize prover input info into binary files * Use_btreemap_for_deterministic_order_of_pie_keys (#2085) * [BREAKING] Compute_missing_builtin_cells_only_in_proof_mode (#2088) * move prover input info to a new seperate file (#2079) * add trace not enabled error * add test to filling holes (#2087) * memory comparision test only for non proof mode cases * Sync with main (#2116) * Remove duplicated `get_val` (#2065) * avoid installing gmp if it is already installed * revert part of the last commit * changelog * remove unwanted file * CI: Make cache keys depend on Cairo version (#2056) * Add Makefile and requirements.txt to cache key * Don't fetch cairo stwo exclusive programs * Remove empty file * Restrict caching Cairo programs Revert how the Rust workflow uses the Cairo program paths to calculate the cache keys. This change would imply the branch only adds Makefile and requirements.txt to the cache key computation. --------- Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> * dev: make Memory::get `pub` (#2039) * dev: make Memory::get `pub` * edit changelog * dev: expose get_maybe_relocatable instead * add comment on borrowed variant * add tests * feat(breaking): add support for hint accessible scopes (#2042) * feat: add support for hint accessible scopes update changelog * Update vm/src/hint_processor/hint_processor_definition.rs Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> * feat: add support for alias identifiers destination in program serde (#2071) * feat: add support for aliases destination in program serde * add changelog --------- Co-authored-by: Julián González Calderón <[email protected]> * fix: Add boundary tests for SecpSplitOutOfRange in secp_utils (#2062) * fix: Add boundary tests for SecpSplitOutOfRange in secp_utils * Update secp_utils.rs * Update CHANGELOG.md * Update secp_utils.rs * remove optimizations * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * empty commit to fix CI --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> * docs: add --run_from_cairo_pie documentation for Cairo 0 and Cairo 1 (#2077) * docs: add --run_from_cairo_pie flag usage documentation for Cairo 0 * docs: add --run_from_cairo_pie flag usage documentation for Cairo 1 * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Update README.md * Update README.md * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Update README.md Co-authored-by: Gabriel Bosio <[email protected]> * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> * Fix WRITE_DIVMOD_SEGMENT hint (#2078) * Minor fixes - use CAIRO_PRIME * Add error handling * Update CHANGELOG.md * Bump cairo-lang to 0.13.5 (#1959) * Update cairo-lang versin * Update changelog * Add new hints * Specify prime in new hints * Only apply mod floor if prime is not CAIRO_PRIME * Properly implement pack for a different prime * Fix pack in compute_doubling_slope * Add negative_points.cairo test * Add try_get_point_from_x for negative points * Add double_x test for negative points * Allow to many arguments * Add codecov to cairo-0-secp-hints feature * Prepare for Release v3.0.0-rc.1 (#2092) * Update version * Update lock * Update toolchain * Update changelog * Fix clippy * Update toolchain in CI * fix: correct cache keys for no-std test coverage in CI (#2093) * Update rust.yml * Update rust.yml * Update rust toolchain to 1.87.0 (#2100) * update rust toolchain to 1.87.0 * remove uneeded file * update rust in workflows * update changelog * clippy * clippy * remove unneeded clippy allow * fix Changelog link (#2104) * Improve memory_segments coverage (#2110) * Add tests for .gen_arg() and .write_arg() * Add test for .is_valid_memory_value() * Assert contents of memory segments --------- Co-authored-by: Franco Giachetta <[email protected]> Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Mathieu <[email protected]> Co-authored-by: VolodymyrBg <[email protected]> Co-authored-by: GarmashAlex <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: DiegoC <[email protected]> * Revert "Sync with main (#2116)" (#2117) This reverts commit 7269a8f. * Bump cairo-lang to 0.13.5 (#1959) (#2118) * Update cairo-lang versin * Update changelog * Add new hints * Specify prime in new hints * Only apply mod floor if prime is not CAIRO_PRIME * Properly implement pack for a different prime * Fix pack in compute_doubling_slope * Add negative_points.cairo test * Add try_get_point_from_x for negative points * Add double_x test for negative points * Allow to many arguments * Add codecov to cairo-0-secp-hints feature Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Enable_using_secure_run_in_proof_mode (#2113) * take ownershop instad of clone * Fixed bad submodule (#2131) * Added support for large files in PIE (#2136) * [starkware-development] Pin types-rs version to the one set in lockfile (#2142) * Update changelog * Pin types-rs version * Include_output_builtin_in_prover_input_info (#2138) * add relocate trace flag to the runner * remove prover input info struct and add getters instead (#2149) * Use_BTreeMap_in_pie_additional_data (#2162) * Update CHANGELOG for previous PR --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Stavbe <[email protected]> Co-authored-by: Franco Giachetta <[email protected]> Co-authored-by: yuvalsw <[email protected]> Co-authored-by: YairVaknin-starkware <[email protected]> Co-authored-by: Mathieu <[email protected]> Co-authored-by: VolodymyrBg <[email protected]> Co-authored-by: GarmashAlex <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: DiegoC <[email protected]>
* Add starkware-development to CI (like another main) (#2025) * Keep None memory cells for the prover input info (#2021) * CI: Fix cache not found error (#2026) * Fix flow notation * Fix dependency * Remove dependancy in cairo pie when collectiog builtin segments info (#2022) * Add Commit Signing section (#2019) * Add Commit Signing section * Clarify that this only affects to internal branches Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Franco Giachetta <[email protected]> * use btreemap instead of hashmap for deterministic iteration order. (#2023) * fill holes is builtins segments * fill holes is builtins segments * Added hints felt unpacking for blake (#2032) This PR is an as-is copy of AlonT's PR pushed to a fork repo. * add prover input info flag to vm-cli * set disable trace padding for prover input info * Add_perp_and_dex_w_bitwise_layouts (#2067) * Fix_zero_offset_output_base_assumption (#2068) * add flag to serialize prover input info into binary files * Use_btreemap_for_deterministic_order_of_pie_keys (#2085) * [BREAKING] Compute_missing_builtin_cells_only_in_proof_mode (#2088) * move prover input info to a new seperate file (#2079) * add trace not enabled error * add test to filling holes (#2087) * memory comparision test only for non proof mode cases * Sync with main (#2116) * Remove duplicated `get_val` (#2065) * avoid installing gmp if it is already installed * revert part of the last commit * changelog * remove unwanted file * CI: Make cache keys depend on Cairo version (#2056) * Add Makefile and requirements.txt to cache key * Don't fetch cairo stwo exclusive programs * Remove empty file * Restrict caching Cairo programs Revert how the Rust workflow uses the Cairo program paths to calculate the cache keys. This change would imply the branch only adds Makefile and requirements.txt to the cache key computation. --------- Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> * dev: make Memory::get `pub` (#2039) * dev: make Memory::get `pub` * edit changelog * dev: expose get_maybe_relocatable instead * add comment on borrowed variant * add tests * feat(breaking): add support for hint accessible scopes (#2042) * feat: add support for hint accessible scopes update changelog * Update vm/src/hint_processor/hint_processor_definition.rs Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> * feat: add support for alias identifiers destination in program serde (#2071) * feat: add support for aliases destination in program serde * add changelog --------- Co-authored-by: Julián González Calderón <[email protected]> * fix: Add boundary tests for SecpSplitOutOfRange in secp_utils (#2062) * fix: Add boundary tests for SecpSplitOutOfRange in secp_utils * Update secp_utils.rs * Update CHANGELOG.md * Update secp_utils.rs * remove optimizations * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * empty commit to fix CI --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> * docs: add --run_from_cairo_pie documentation for Cairo 0 and Cairo 1 (#2077) * docs: add --run_from_cairo_pie flag usage documentation for Cairo 0 * docs: add --run_from_cairo_pie flag usage documentation for Cairo 1 * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Update README.md * Update README.md * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Update README.md Co-authored-by: Gabriel Bosio <[email protected]> * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> * Fix WRITE_DIVMOD_SEGMENT hint (#2078) * Minor fixes - use CAIRO_PRIME * Add error handling * Update CHANGELOG.md * Bump cairo-lang to 0.13.5 (#1959) * Update cairo-lang versin * Update changelog * Add new hints * Specify prime in new hints * Only apply mod floor if prime is not CAIRO_PRIME * Properly implement pack for a different prime * Fix pack in compute_doubling_slope * Add negative_points.cairo test * Add try_get_point_from_x for negative points * Add double_x test for negative points * Allow to many arguments * Add codecov to cairo-0-secp-hints feature * Prepare for Release v3.0.0-rc.1 (#2092) * Update version * Update lock * Update toolchain * Update changelog * Fix clippy * Update toolchain in CI * fix: correct cache keys for no-std test coverage in CI (#2093) * Update rust.yml * Update rust.yml * Update rust toolchain to 1.87.0 (#2100) * update rust toolchain to 1.87.0 * remove uneeded file * update rust in workflows * update changelog * clippy * clippy * remove unneeded clippy allow * fix Changelog link (#2104) * Improve memory_segments coverage (#2110) * Add tests for .gen_arg() and .write_arg() * Add test for .is_valid_memory_value() * Assert contents of memory segments --------- Co-authored-by: Franco Giachetta <[email protected]> Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Mathieu <[email protected]> Co-authored-by: VolodymyrBg <[email protected]> Co-authored-by: GarmashAlex <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: DiegoC <[email protected]> * Revert "Sync with main (#2116)" (#2117) This reverts commit 7269a8f. * Bump cairo-lang to 0.13.5 (#1959) (#2118) * Update cairo-lang versin * Update changelog * Add new hints * Specify prime in new hints * Only apply mod floor if prime is not CAIRO_PRIME * Properly implement pack for a different prime * Fix pack in compute_doubling_slope * Add negative_points.cairo test * Add try_get_point_from_x for negative points * Add double_x test for negative points * Allow to many arguments * Add codecov to cairo-0-secp-hints feature Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Enable_using_secure_run_in_proof_mode (#2113) * take ownershop instad of clone * Fixed bad submodule (#2131) * Added support for large files in PIE (#2136) * [starkware-development] Pin types-rs version to the one set in lockfile (#2142) * Update changelog * Pin types-rs version * Include_output_builtin_in_prover_input_info (#2138) * add relocate trace flag to the runner * remove prover input info struct and add getters instead (#2149) * Use_BTreeMap_in_pie_additional_data (#2162) * Update CHANGELOG for previous PR --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Stavbe <[email protected]> Co-authored-by: Franco Giachetta <[email protected]> Co-authored-by: yuvalsw <[email protected]> Co-authored-by: YairVaknin-starkware <[email protected]> Co-authored-by: Mathieu <[email protected]> Co-authored-by: VolodymyrBg <[email protected]> Co-authored-by: GarmashAlex <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: DiegoC <[email protected]>
This change is